[PATCH] D26461: Tread TSan LLVM flags to driver: add TSan controlling flags to clang.

Aleksey Shlyapnikov via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 9 12:00:16 PST 2016


alekseyshl added inline comments.


================
Comment at: lib/Frontend/CompilerInvocation.cpp:735
+                   OPT_fno_sanitize_thread_data_races,
+                   Opts.SanitizeThreadDataRaces);
+  Opts.SanitizeThreadStackTraces =
----------------
eugenis wrote:
> It seems common to hardcode the default option value here.
> The same in SanitizerArgs.cpp.
True, but the default value for these flags is already mentioned in more than one place, why not to try to reduce the complexity?


https://reviews.llvm.org/D26461





More information about the cfe-commits mailing list