[PATCH] D26435: Use unique_ptr for cached tokens for default arguments in C++.
David Tarditi via cfe-commits
cfe-commits at lists.llvm.org
Wed Nov 9 10:20:23 PST 2016
dtarditi updated this revision to Diff 77373.
dtarditi added a comment.
Thanks for the code review feedback - I've addressed it. Yes, we should use reset() instead of release(). I also deleted the unnecessary brackets. I don't have commit access, so if this looks good, could someone commit this on my behalf?
https://reviews.llvm.org/D26435
Files:
include/clang/Parse/Parser.h
include/clang/Sema/DeclSpec.h
lib/Parse/ParseCXXInlineMethods.cpp
lib/Parse/ParseDecl.cpp
lib/Parse/ParseDeclCXX.cpp
lib/Sema/DeclSpec.cpp
lib/Sema/SemaDeclCXX.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D26435.77373.patch
Type: text/x-patch
Size: 7246 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20161109/ca31fe71/attachment.bin>
More information about the cfe-commits
mailing list