[PATCH] D26418: [clang-tidy] Add '-suppress-checks-filter' option to suppress diagnostics from certain files

Nikita Kakuev via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 9 02:31:16 PST 2016


nkakuev added a comment.

In https://reviews.llvm.org/D26418#590417, @malcolm.parsons wrote:

> In https://reviews.llvm.org/D26418#590383, @nkakuev wrote:
>
> > The warning is caused by a third-party code, but header filter won't help you to suppress it since it now relates to your sources.
>
>
> The header filter suppresses the warning location, but the note locations are in the main file so they unsuppress the warning.
>
> It sounds like you want note locations to be ignored.


I want a convenient instrument to suppress unwanted diagnostics. Even if I change clang-tidy to ignore note locations, it would still be impractical to use '-header-filter' to //exclude// diagnostics from certain headers. Header filter was designed to //include// headers, not to //exclude// them. Trying to exclude "these m directories and that n files" is close to impossible using a single regular expression. Plus, even if I manage to do this, I'll be ignoring all diagnostics and not only the faulty ones.

Suppress-check-filter is specifically designed to //exclude// headers and doesn't require abusing regular expressions to do this. Plus, it allows a user to specify what diagnostics he doesn't want, instead of ignoring everything.


https://reviews.llvm.org/D26418





More information about the cfe-commits mailing list