[PATCH] D26311: Use AnalyzerOptions::getRegisteredCheckers() instead of clang/StaticAnalyzer/Checkers/Checkers.inc

Haojian Wu via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 7 16:02:50 PST 2016


hokein added inline comments.


================
Comment at: clang-tidy/ClangTidy.cpp:297
+  const auto &RegisteredCheckers =
+      AnalyzerOptions::getRegisteredCheckers(IncludeExperimentalCheckers);
+  bool AnalyzerChecksEnabled = false;
----------------
alexfh wrote:
> hokein wrote:
> > Since the default argument of  this function is `false` already. Can we use `AnalyzerOptions::getRegisteredCheckers();` directly?
> I wanted to be explicit about this choice on the caller side as well.
I see, but `IncludeExperimentalCheckers` is not needed here. How about `AnalyzerOptions::getRegisteredCheckers(/*IncludeExperimental=*/false);`?


https://reviews.llvm.org/D26311





More information about the cfe-commits mailing list