[PATCH] D25659: [clang-tidy] Avoid running aliased checks twice

Alexander Kornienko via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 7 14:20:04 PST 2016


alexfh requested changes to this revision.
alexfh added a comment.
This revision now requires changes to proceed.

In https://reviews.llvm.org/D25659#588658, @alexfh wrote:

> I think, silently choosing one of the checks may be confusing and counter-intuitive. Should we just warn in case we see the same check enabled by multiple aliases?


And by "aliases" I mean different names under which the check is registered. I'm not sure I see the benefit of introducing a separate concept and a separate API for registering checks under multiple names. This introduces another sort of dynamic binding, which we have to have good reasons for.


https://reviews.llvm.org/D25659





More information about the cfe-commits mailing list