[PATCH] D26306: [AVX-512] Make VBMI instruction set enabling imply that the BWI instruction set is also enabled.

[Zvi Rackover via cfe-commits]

zvi added inline comments.


================
Comment at: lib/Basic/Targets.cpp:3353
       setSSELevel(Features, AVX512F, Enabled);
+    // Enable BWI instruction is VBMI is being enabled.
+    if (Name == "avx512vbmi" && Enabled)
----------------
is -> if


================
Comment at: test/Preprocessor/x86_target_features.c:212
 
+// RUN: %clang -target i386-unknown-unknown -march=atom -mavx512vbmi -mno-avx512vbmi -x c -E -dM -o - %s | FileCheck -match-full-lines --check-prefix=AVX512VBMINOAVX512BW %s
+
----------------
Test is turning on and then off the same feature. Did you mean -mavx512bw -mno-avx512vbmi ?

If the latter, I would prefer the compiler shout at me for providing contradicting flags than let the last flag win. Consider enforcing this in handleTargetFeatures().




https://reviews.llvm.org/D26306