[PATCH] D26195: Ignore incomplete types when determining whether they are expensive to copy

Alexander Kornienko via cfe-commits cfe-commits at lists.llvm.org
Fri Nov 4 21:41:26 PDT 2016


alexfh added a comment.

Thank you for the fix! One late comment inline.



================
Comment at: clang-tools-extra/trunk/test/clang-tidy/performance-unnecessary-value-param.cpp:241
+
+// Ensure that incomplete types result in an error from the frontend and not a
+// clang-tidy diagnostic about IncompleteType being expensive to copy.
----------------
Please move this test to a separate test file and revert the RUN line here. 


Repository:
  rL LLVM

https://reviews.llvm.org/D26195





More information about the cfe-commits mailing list