[PATCH] D23418: [analyzer] Added a reusable constraint system to the CloneDetector
Mehdi AMINI via cfe-commits
cfe-commits at lists.llvm.org
Thu Nov 3 17:40:27 PDT 2016
mehdi_amini added a comment.
(Quick stylistic comments)
================
Comment at: include/clang/Analysis/CloneDetection.h:224
- /// \brief Searches the provided statements for clones.
+ /// \brief Represents a way to filter clones from a list of clone groups.
///
----------------
Use of `\brief` is deprecated (we enabled auto brief quite some time ago).
================
Comment at: include/clang/Analysis/CloneDetection.h:417
+public:
+ virtual ~MatchingVariablePatternConstraint() {}
+
----------------
`= default`
================
Comment at: include/clang/Analysis/CloneDetection.h:419
+
+ virtual bool
+ acceptsPrototype(const StmtSequence &Prototype,
----------------
No need for virtual on override.
https://reviews.llvm.org/D23418
More information about the cfe-commits
mailing list