[PATCH] D26288: Deduplicate replacements by FileEntry instead of file names.
Eric Liu via cfe-commits
cfe-commits at lists.llvm.org
Thu Nov 3 14:29:50 PDT 2016
ioeric added inline comments.
================
Comment at: lib/Tooling/Core/Replacement.cpp:578
+ continue;
+ ProcessedFileEntries.insert(FE);
+ Result[Entry.first] = std::move(Entry.second);
----------------
alexshap wrote:
> (saves 2 lines of code) (although not particularly important)
> if (ProcessedFileEntries.insert(FE).second)
> Result[Entry.first] = std::move(Entry.second);
Always nice to save a few lines :) Thanks!
https://reviews.llvm.org/D26288
More information about the cfe-commits
mailing list