[PATCH] D26271: [PPC} add extract significand/ extract exponent/test data class for vector float and vector double -- clang portion
Nemanja Ivanovic via cfe-commits
cfe-commits at lists.llvm.org
Thu Nov 3 01:34:32 PDT 2016
nemanjai added a comment.
LGTM but I'll let @kbarton have a look and provide the final approval.
================
Comment at: lib/Headers/altivec.h:15629
+#define vec_test_data_class(__a, __b) \
+ _Generic((__a), \
+ vector float: \
----------------
I don't know what happens if the type of the first argument is neither of the two types, but I think we should verify that something sane happens. Namely, some sort of overload resolution error message.
Repository:
rL LLVM
https://reviews.llvm.org/D26271
More information about the cfe-commits
mailing list