[PATCH] D26166: [Sema] Don't issue analysis-based warnings when a fatal error has occurred

[Richard Smith via cfe-commits]

rsmith accepted this revision.
rsmith added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lib/Sema/SemaTemplateInstantiate.cpp:213-214
+  // Don't allow further instantiation if a fatal error and an uncompilable
+  // error have occcured. Any diagnostics we might have raised will not be
+  // visible.
+  if (SemaRef.Diags.hasFatalErrorOccurred() &&
----------------
Maybe "Any diagnostics we might have raised will not be visible, and we do not need to construct a correct AST." to justify the two checks?


https://reviews.llvm.org/D26166