[PATCH] D26139: Tests for strings conversions under libcpp-no-exceptions

Asiri Rathnayake via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 2 03:00:43 PDT 2016


rmaprath added a comment.

Would it be more cleaner to separate out the exceptions-related tests into their own functions? So, we'd have the two functions `test_withexceptions()` and `test_noexceptions()`; the former will only be invoked when testing the normal library variant, the latter will be invoked for all the library variants.

WDYT?

/ Asiri


https://reviews.llvm.org/D26139





More information about the cfe-commits mailing list