[PATCH] D26143: [modules] Mark deleted functions as implicitly inline to allow merging

Richard Smith via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 31 10:49:52 PDT 2016


rsmith accepted this revision.
rsmith added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lib/Sema/SemaDeclCXX.cpp:13875-13876
+  //  A deleted function is implicitly inline.
+  // NOTE: Modules cannot correctly merge deleted functions unless they are
+  // inline.
+  Fn->setImplicitlyInline();
----------------
This comment is effectively saying "Modules relies on the AST being correct". I don't think we need it.


https://reviews.llvm.org/D26143





More information about the cfe-commits mailing list