[PATCH] D26145: DebugInfo: support for DW_TAG_atomic_type

[Adrian Prantl via cfe-commits]

aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.

LGTM with inline comments addressed.



================
Comment at: test/CodeGen/debug-info-atomic.c:3
+
+// CHECK: !DIDerivedType(tag: DW_TAG_const_type
+// CHECK: !DIDerivedType(tag: DW_TAG_atomic_type
----------------
Why do we need the const here?


================
Comment at: test/CodeGen/debug-info-atomic.c:4
+// CHECK: !DIDerivedType(tag: DW_TAG_const_type
+// CHECK: !DIDerivedType(tag: DW_TAG_atomic_type
+_Atomic const int i;
----------------
Can you check that it is actually the DIVariable "i" that has the atomic type?


https://reviews.llvm.org/D26145