[PATCH] D25624: Added 'inline' attribute to basic_string's destructor

Aditya Kumar via cfe-commits cfe-commits at lists.llvm.org
Fri Oct 28 13:43:21 PDT 2016


hiraditya added inline comments.


================
Comment at: libcxx/include/string:1837
 template <class _CharT, class _Traits, class _Allocator>
+inline _LIBCPP_EXTERN_TEMPLATE_INLINE_VISIBILITY
 basic_string<_CharT, _Traits, _Allocator>::~basic_string()
----------------
EricWF wrote:
> The attribute should appear on the first declaration not the out-of-line definition. Feel free to commit after making that change.
Okay, thanks for the correction.


https://reviews.llvm.org/D25624





More information about the cfe-commits mailing list