[PATCH] D25204: Register Calling Convention, Clang changes

[Reid Kleckner via cfe-commits]

rnk added a comment.

In https://reviews.llvm.org/D25204#581477, @erichkeane wrote:

> In general, I can see the benefit of this rule, however in the case of calling conventions, I would think that keeping them all orthogonal is important.  Having "most" calling conventions work one way, and a couple a different way seems like a bigger problem.


I agree. I don't think introducing a __regcall keyword is going to cause much real world breakage.



================
Comment at: include/clang/Basic/Attr.td:815
+  let Spellings = [GCC<"regcall">, Keyword<"__regcall">,
+                   Keyword<"_regcall">];
+  let Documentation = [RegCallDocs];
----------------
Can we not add the single underscore keyword version? That's outside the implementer's namespace.


https://reviews.llvm.org/D25204