[PATCH] D23752: [cmake] Respect LLVM_RUNTIMES_LIBDIR_SUFFIX

[Chandler Carruth via cfe-commits]

chandlerc added a comment.

I don't get it.

There is nothing "RUNTIMES" about it. And this variable is actually used to produce real libraries: libclang, etc.

It's just the LIBDIR_SUFFIX. That's it. The reason it is called CLANG_LIBDIR_SUFFIX and set from LLVM_LIBDIR_SUFFIX is to support using the CMake build of Clang in a standalone mode where there *isn't* a LLVM_LIBDIR_SUFFIX and instead the CLANG_LIBDIR_SUFFIX needs to be set directly.

So I'm really not understanding what benefit this change is bringing.

And the other comment in the CMake file that the CLANG_LIBDIR_SUFFIX must exactly match whatever LLVM_LIBDIR_SUFFIX is remains, AFAICT, 100% correct.


https://reviews.llvm.org/D23752