[PATCH] D26026: [libcxx] Make regex_match backtrack when search fails
Marshall Clow via cfe-commits
cfe-commits at lists.llvm.org
Thu Oct 27 06:58:06 PDT 2016
mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
LGTM. One minor suggestion (adding a comment to a test).
================
Comment at: libcxx/test/std/re/re.alg/re.alg.match/ecma.pass.cpp:374
std::cmatch m;
const char s[] = "tournament";
+ assert(std::regex_match(s, m, std::regex("tour|to|tournament")));
----------------
I would be tempted to put a reference to http://wg21.link/LWG2273 here. (in a comment)
https://reviews.llvm.org/D26026
More information about the cfe-commits
mailing list