[PATCH] D21845: [Driver][OpenMP] Add specialized action builder for OpenMP offloading actions.

[Hal Finkel via cfe-commits]

hfinkel accepted this revision.
hfinkel added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lib/Driver/Driver.cpp:1949
+    SpecializedBuilders.push_back(new OpenMPActionBuilder(C, Args, Inputs));
+
     //
----------------
sfantao wrote:
> hfinkel wrote:
> > Since we can have both OpenMP offloading and CUDA, please add a test that the phases work correctly for that case (or that we produce an error if that can't currently work correctly).
> Added new test for that. The phases generation should work well if CUDA and OpenMP offloading are used on the same file. 
> 
> However, the bindings for these phases cannot be generated given that the NVPTX toolchain support for OpenMP is not implemented yet and the CUDA implementation interprets actions differently, e.g. in CUDA linking is the combination of binaries of different devices (GPUs) whereas for OpenMP actual linking takes place, i.e. symbols are resolved by looking into other compilation units.
> 
Okay; after this is committed, please file a PR showing what happens and explaining the issue.


https://reviews.llvm.org/D21845