[PATCH] D22346: [Clang-tidy] CERT-MSC50-CPP (std:rand() )

Aaron Ballman via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 26 14:55:30 PDT 2016


aaron.ballman added a comment.

In https://reviews.llvm.org/D22346#580242, @falho wrote:

> removed semicolon, and replaced it with a comma that only appears in .cpp diagnostics


The semicolon was the correct punctuator to use, but thank you for moving it into the cpp message.

> test cases corrected according to this
> 
> removed junk .swo file

Thanks!



================
Comment at: clang-tidy/cert/LimitedRandomnessCheck.cpp:30
+  if (getLangOpts().CPlusPlus) {
+    msg = ", use C++11 random library instead";
+  }
----------------
Switch the "," to ";", and remove the curly braces.


https://reviews.llvm.org/D22346





More information about the cfe-commits mailing list