[PATCH] D25204: Register Calling Convention, Clang changes

[David Majnemer via cfe-commits]

majnemer added inline comments.


================
Comment at: lib/AST/MicrosoftMangle.cpp:433
   Out << Prefix;
+
   mangleName(D);
----------------
Please remove this stray newline.


================
Comment at: lib/CodeGen/TargetInfo.cpp:3333
+      if (classifyArgumentType(FD->getType(),
+                               std::numeric_limits<unsigned>::max(),
+                               LocalNeededInt, LocalNeededSSE, true)
----------------
I think UINT_MAX is more popular than using `std::numeric_limits` for this purpose in LLVM/Clang.


================
Comment at: lib/CodeGen/TargetInfo.cpp:3337-3338
+        NeededInt = NeededSSE = 0;
+        return getIndirectReturnResult(Ty);
+      } else {
+        NeededInt += LocalNeededInt;
----------------
Please avoid else after return: http://llvm.org/docs/CodingStandards.html#don-t-use-else-after-a-return


https://reviews.llvm.org/D25204