[PATCH] D25640: [CUDA] [AST] Allow isInlineDefinitionExternallyVisible to be called on functions without bodies.

Justin Lebar via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 25 19:10:37 PDT 2016


jlebar added a comment.

In https://reviews.llvm.org/D25640#579238, @tra wrote:

> I'm OK with the change, but the comments suggest that things may be more complicated.
>  How about disabling assert for CUDA only?


I don't think that is the right approach.  This function has nothing to do with CUDA, so either the assertion is valid and we shouldn't be calling it this way, or it's not valid and we should remove the assertion.

Richard, would appreciate some help with this one.


https://reviews.llvm.org/D25640





More information about the cfe-commits mailing list