[PATCH] D25869: [Driver] Add unit tests for DetectDistro()

[Benjamin Kramer via cfe-commits]

bkramer added a comment.

Very nice.



================
Comment at: unittests/Driver/ToolChainsTest.cpp:15
+// FIXME: I presume this is not the correct way of doing this
+#include "../lib/Driver/ToolChains.h"
+#include "clang/Basic/VirtualFileSystem.h"
----------------
Yeah. It's better to hoist the enum + the decl for detectDistro into a public header under include/clang/Driver and include it from here.


https://reviews.llvm.org/D25869