[libcxx] r249738 - Split <ctype.h> out of <cctype>.

Bruno Cardoso Lopes via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 24 15:30:31 PDT 2016


> Sure, go ahead.

I committed in r284797 and r284801 (libcxx). There's one minor issue
I've found: the changes for the builtins affecting non submodule local
visibility broke current users of plain "-fmodules" against our
frameworks in public SDKs, in 10.11 & 10.12. I've attached a patch to
work around that for the time being: make the new behavior dependent
on local vis. Can you take a look?

> Hmm. Ideally, we should try to pick something that captures the spirit of
> "only non-modular headers and headers from used modules". Something like
> "ignore_modules_not_declared_used", but less wordy?

Right. It's gonna be hard to shrink this to a meaningful short name.
What about a more generic "no_escape"?  "no_undeclared_headers"?

Thanks again,

-- 
Bruno Cardoso Lopes
http://www.brunocardoso.cc
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Modules-Fix-side-effect-of-built-in-changes-from-r28.patch
Type: application/octet-stream
Size: 3081 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20161024/c31a4d7c/attachment.obj>


More information about the cfe-commits mailing list