r285028 - CodeGen: remove incorrect temporary Twine

Saleem Abdulrasool via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 24 14:25:57 PDT 2016


Author: compnerd
Date: Mon Oct 24 16:25:57 2016
New Revision: 285028

URL: http://llvm.org/viewvc/llvm-project?rev=285028&view=rev
Log:
CodeGen: remove incorrect temporary Twine

Twines should not be stack allocated.  This somehow managed to get past me.

Modified:
    cfe/trunk/lib/CodeGen/CGObjCMac.cpp

Modified: cfe/trunk/lib/CodeGen/CGObjCMac.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGObjCMac.cpp?rev=285028&r1=285027&r2=285028&view=diff
==============================================================================
--- cfe/trunk/lib/CodeGen/CGObjCMac.cpp (original)
+++ cfe/trunk/lib/CodeGen/CGObjCMac.cpp Mon Oct 24 16:25:57 2016
@@ -6282,8 +6282,8 @@ void CGObjCNonFragileABIMac::GenerateCat
 
   Values[1] = ClassGV;
   std::vector<llvm::Constant*> Methods;
-  Twine ListName =
-      Interface->getObjCRuntimeNameAsString() + "_$_" + OCD->getName();
+  std::string ListName =
+      (Interface->getObjCRuntimeNameAsString() + "_$_" + OCD->getName()).str();
 
   for (const auto *I : OCD->instance_methods())
     // Instance methods should always be defined.




More information about the cfe-commits mailing list