[PATCH] D25895: [MS ABI] Reuse getVFPtrOffsets instead of using getClassAtVTableLocation

Reid Kleckner via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 24 12:33:27 PDT 2016


rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm



================
Comment at: lib/CodeGen/MicrosoftCXXABI.cpp:1779-1780
+  MicrosoftVTableContext &VFTContext = CGM.getMicrosoftVTableContext();
   MicrosoftVTableContext::MethodVFTableLocation ML =
-      CGM.getMicrosoftVTableContext().getMethodVFTableLocation(GD);
+      VFTContext.getMethodVFTableLocation(GD);
+
----------------
Idle thought for future patches: we should feel ML into adjustThisArgumentForVirtualCall to save the double hash lookup.


https://reviews.llvm.org/D25895





More information about the cfe-commits mailing list