[PATCH] D25731: [analyzer] NumberObjectConversion: Support OSNumber and CFNumberRef.

Artem Dergachev via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 24 08:41:35 PDT 2016


NoQ updated this revision to Diff 75586.
NoQ marked an inline comment as done.
NoQ added a comment.

- Update warning messages. I think it's better to pattern-match for integer sizes after all when we're suggesting API, this especially looks ugly for OSNumber (which is rare).
- Add tests for converting `CFNumberRef` into `intptr_t`.
- An unrelated change: Move casts to bools to non-pedantic mode (i mistakenly thought this check is loud).


https://reviews.llvm.org/D25731

Files:
  lib/StaticAnalyzer/Checkers/NumberObjectConversionChecker.cpp
  test/Analysis/number-object-conversion.c
  test/Analysis/number-object-conversion.cpp
  test/Analysis/number-object-conversion.m

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D25731.75586.patch
Type: text/x-patch
Size: 31043 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20161024/26f6056e/attachment-0001.bin>


More information about the cfe-commits mailing list