[PATCH] D25888: Add support for __builtin_os_log_format[_buffer_size]
David Majnemer via cfe-commits
cfe-commits at lists.llvm.org
Fri Oct 21 23:05:42 PDT 2016
majnemer added inline comments.
================
Comment at: clang/include/clang/Analysis/Analyses/OSLog.h:117-129
+ return std::any_of(
+ Items.begin(), Items.end(),
+ [](const OSLogBufferItem &item) { return item.getIsPrivate(); });
+ }
+
+ bool getHasPublicItems() const {
+ return std::any_of(
----------------
`llvm::any_of`
================
Comment at: clang/include/clang/Analysis/Analyses/OSLog.h:137-140
+ if (getHasPrivateItems())
+ result |= 0x01;
+ if (getHasNonScalar())
+ result |= 0x02;
----------------
Magic numbers.
https://reviews.llvm.org/D25888
More information about the cfe-commits
mailing list