[PATCH] D25888: Add support for __builtin_os_log_format[_buffer_size]

[David Majnemer via cfe-commits]

majnemer added a comment.

You could use `llvm::any_of` instead of `std::any_of`.



================
Comment at: clang/include/clang/Analysis/Analyses/OSLog.h:84-86
+      result |= 0x01;
+    if (getIsPublic())
+      result |= 0x02;
----------------
IsPublic/IsPrivate instead of magic numbers?


================
Comment at: clang/lib/Sema/SemaChecking.cpp:3493
+  Arg = Arg->IgnoreParenCasts();
+  StringLiteral *Literal = dyn_cast<StringLiteral>(Arg);
+  if (!Literal) {
----------------
`auto *`


https://reviews.llvm.org/D25888