[PATCH] D25882: Remove special error recovery for ::(id)

Reid Kleckner via cfe-commits cfe-commits at lists.llvm.org
Fri Oct 21 16:04:09 PDT 2016


rnk added inline comments.


================
Comment at: lib/Parse/ParseExprCXX.cpp:73-75
   PP.EnterToken(ColonToken);
   if (!AtDigraph)
     PP.EnterToken(DigraphToken);
----------------
rsmith wrote:
> This seems to mess up the cached token buffer in the same way; it's a little surprising we don't see problems here too.
Fuzzing shows that there are more ways to trigger this assertion, so whether we keep this recovery mode or not, we might want to implement that token rewrite functionality.


https://reviews.llvm.org/D25882





More information about the cfe-commits mailing list