[PATCH] D20811: [analyzer] Model some library functions

[Devin Coughlin via cfe-commits]

dcoughlin accepted this revision.
dcoughlin added a comment.

This looks great!



================
Comment at: lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:694
+            INVALIDATION_APPROACH(EvalCallAsPure))
+      CASE // Is certainly uppercase.
+        ARGUMENT_CONDITION(ARG_NO(0), WithinRange)
----------------
I think think this comment should say 'lowercase'.


================
Comment at: lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:702
+      END_CASE
+      CASE // Is ascii but not uppercase.
+        ARGUMENT_CONDITION(ARG_NO(0), WithinRange)
----------------
Same here.


https://reviews.llvm.org/D20811