[PATCH] D25866: [Sema] Support implicit scalar to vector conversions

[Akira Hatanaka via cfe-commits]

ahatanak added inline comments.


================
Comment at: lib/Sema/SemaExpr.cpp:8044
   // the vector element type and splat.
-  // FIXME: this should also work for regular vector types as supported in GCC.
-  if (!RHSVecType && isa<ExtVectorType>(LHSVecType)) {
+  if (!RHSVecType && isa<VectorType>(LHSVecType)) {
     if (!tryVectorConvertAndSplat(*this, &RHS, RHSType,
----------------
ahatanak wrote:
> Is this the same as "!RHSVecType && LHSVecType" in this context?
Actually, LHS's type should be a vector here if RHS isn't a vector since CheckVectorOperands is called only when at least one operand is a vector.


https://reviews.llvm.org/D25866