[PATCH] D25647: [clang-tidy] Don't use a SmallSetVector of an enum.
Justin Lebar via cfe-commits
cfe-commits at lists.llvm.org
Fri Oct 21 09:02:17 PDT 2016
jlebar added a comment.
Thank you very much for the review!
================
Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/SpecialMemberFunctionsCheck.cpp:103
+ auto &Members = ClassWithSpecialMembers[ID];
+ if (find(Members, Kind) == Members.end()) Members.push_back(Kind);
+ }
----------------
aaron.ballman wrote:
> Please drop the `push_back()` onto its own line.
This was actually how clang-tidy formatted the line. My understanding is that we go with that in llvm projects? Unless you're saying I have an outdated clang-tidy, in which case I will investigate that.
Repository:
rL LLVM
https://reviews.llvm.org/D25647
More information about the cfe-commits
mailing list