[PATCH] D25450: [clang-tidy] Fix identifier naming in macro args.

[Jason Henline via cfe-commits]

jhen marked an inline comment as done.
jhen added inline comments.


================
Comment at: clang-tidy/readability/IdentifierNamingCheck.cpp:654
+      RangeIsEntirelyWithinMacroArgument || !RangeContainsMacroExpansion;
+  Failure.ShouldFix = Failure.ShouldFix && RangeCanBeFixed;
 }
----------------
aaron.ballman wrote:
> We could do an early return if `ShouldFix` is already false and simplify this expression with `ShouldFix = RangeCanBeFixed;`, can't we?
Thanks for pointing that out. The early exit is much more efficient.


https://reviews.llvm.org/D25450