[PATCH] D25747: [clang-tidy] Fix an assertion failure in cppcoreguidelines-pro-type-member-init.

Aaron Ballman via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 20 06:20:24 PDT 2016


aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp:30
 
+AST_MATCHER(CXXRecordDecl, hasDefaultConstructor) {
+  return Node.hasDefaultConstructor();
----------------
I think this should be a public AST matcher rather than a private one; it seems like it would be generally useful (along with some of the other similar has* functions). However, I think it's fine for this patch.


https://reviews.llvm.org/D25747





More information about the cfe-commits mailing list