[PATCH] D25696: [Driver] Parse Debian version as integer when possible. NFC
Bruno Cardoso Lopes via cfe-commits
cfe-commits at lists.llvm.org
Wed Oct 19 14:33:40 PDT 2016
bruno added inline comments.
================
Comment at: lib/Driver/ToolChains.cpp:3903
+ if (!Data.split('.').first.getAsInteger(10, MajorVersion)) {
+ switch (MajorVersion) {
+ case 5:
----------------
clang-format the `switch`: `case`'s should be aligned with it.
================
Comment at: lib/Driver/ToolChains.cpp:3917
+ }
+ } else {
+ return llvm::StringSwitch<Distro>(Data.split("\n").first)
----------------
You can remove the `else` and just `return llvm::StringSwitch...`
https://reviews.llvm.org/D25696
More information about the cfe-commits
mailing list