[PATCH] D25595: [libcxx] Support std::regex_constants::match_not_null

Marshall Clow via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 19 10:39:51 PDT 2016


mclow.lists added a comment.

In https://reviews.llvm.org/D25595#572043, @timshen wrote:

> BTW, `re.const/re.matchflag/match_flag_type.pass.cpp` contains match_not_bow, but it doesn't actually test the functionality.


It tests that it exists and that it has a sane value - which are a good things to test.
But there are no tests that show that when passed to `regex_search` it does the right thing.


https://reviews.llvm.org/D25595





More information about the cfe-commits mailing list