[PATCH] D25448: [ubsan] Use the object pointer's type info for devirtualized calls

Vedant Kumar via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 19 10:35:24 PDT 2016


vsk updated this revision to Diff 75168.
vsk added a comment.

Thanks for the feedback!

Patch update:

- Pass in the right CalleeDecl to EmitCXXMemberOrOperatorCall. This lets us drop the unnecessary 'DevirtualizedClassTy' optional parameter.
- Extend the test case with John's example (devirt for methods marked 'final'). Since this hasn't yet been implemented in clang, make the checks depend on the relevant bug (PR13127).

Tested with check-ubsan and check-clang.


https://reviews.llvm.org/D25448

Files:
  lib/CodeGen/CGExprCXX.cpp
  test/CodeGenCXX/ubsan-devirtualized-calls.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D25448.75168.patch
Type: text/x-patch
Size: 5766 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20161019/8fbf9d1f/attachment.bin>


More information about the cfe-commits mailing list