[PATCH] D24997: [ClangTidy] Add UsingInserter and NamespaceAliaser
Vassil Vassilev via cfe-commits
cfe-commits at lists.llvm.org
Wed Oct 19 07:15:20 PDT 2016
v.g.vassilev added a subscriber: rsmith.
v.g.vassilev added inline comments.
================
Comment at: clang-tidy/utils/UsingInserter.cpp:58
+ if (AlreadyHasUsingDecl) {
+ AddedUsing.emplace(NameInFunction(Function, QualifiedName.str()));
+ return None;
----------------
bkramer wrote:
> v.g.vassilev wrote:
> > Using emplace seems to break our modules libstdc++ 4.7 builds: http://lab.llvm.org:8011/builders/clang-x86_64-linux-selfhost-modules-2/builds/6066 . Doesn't that break other 4.7 or earlier builds?
> GCC 4.7 isn't supported anymore by LLVM (rL284497) can we update that bot to a newer version of GCC?
It is managed by @rsmith . He should be able to tell.
https://reviews.llvm.org/D24997
More information about the cfe-commits
mailing list