[PATCH] D25762: [clang-move] Move using-decl in old cc.

[Eric Liu via cfe-commits]

ioeric added inline comments.


================
Comment at: clang-move/ClangMove.cpp:356
   Finder->addMatcher(
-      namedDecl(anyOf(functionDecl(isDefinition()), varDecl(isDefinition())),
-                inAnonymousNamespace)
-          .bind("decls_in_anonymous_ns"),
+      usingDecl(InOldCC, unless(InAnonymousNamespace)).bind("using_decl"),
       this);
----------------
Is `UsingDirectiveDecl`, i.e. using namespace decl, included in this case?


================
Comment at: clang-move/ClangMove.cpp:366
       namedDecl(anyOf(functionDecl(isDefinition(), unless(InMovedClass),
+                                   unless(InAnonymousNamespace),
                                    isStaticStorageClass(), InOldCC),
----------------
Seems that filters for `functionDecl` and `varDecl` are the same? Maybe apply them on `namedDecl`?


================
Comment at: test/clang-move/Inputs/multiple_class_test.cpp:9
 
+namespace {
+using a::Move1;
----------------
Can you also add tests where using decls are in classes/functions?


https://reviews.llvm.org/D25762