[libcxx] r249738 - Split <ctype.h> out of <cctype>.

[Richard Smith via cfe-commits]

On Tue, Oct 18, 2016 at 4:30 PM, Bruno Cardoso Lopes <
bruno.cardoso at gmail.com> wrote:

> Hi Richard,
>
> Turns out that the redefinition error was caused because libc++
> modulemap lacked a module for its "string.h", and therefore it would
> be textually included in more than one module, yielding the error.
>
> With the attached patch for libc++ modulemap (extracted from parts of
> a modulemap you previously attached to the thread) + your patch, I can
> successfully compile Darwin and selfhost clang with submodule local
> visibility.


Awesome.


> I can also upstream the patches for you in case your too
> busy, let me know.
>

Sure, go ahead.


> One minor note: the keyword name 'no_undeclared_includes' sounds a bit
> confusing, how about 'direct_uses_only', or something along these
> lines?
>

Hmm. Ideally, we should try to pick something that captures the spirit of
"only non-modular headers and headers from used modules". Something like
"ignore_modules_not_declared_used", but less wordy?


> Thanks,
>
> On Mon, Oct 17, 2016 at 3:59 PM, Bruno Cardoso Lopes
> <bruno.cardoso at gmail.com> wrote:
> >> @Bruno,
> >>
> >> Can you try "-fdiagnostics-show-note-include-stack” so we know the
> other path that leads to string.h?
> >
> > Attached the complete error log (this snippet won't help without full
> > context anyway)
>
> --
> Bruno Cardoso Lopes
> http://www.brunocardoso.cc
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20161018/93c72194/attachment-0001.html>