[PATCH] D25520: [CodeCompletion] Add block placeholders when completing member access for Objective-C block property setters

Alex Lorenz via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 18 03:53:47 PDT 2016


arphaman added a comment.

In https://reviews.llvm.org/D25520#569389, @akyrtzi wrote:

> >   What do you think of the following possible priority heuristic
>
> SGTM.
>
> Changes LGTM. I'd also recommend that as a follow-up patch it would be great to extend the setter completion to variables as well (global variables, fields, ivars, etc.)


Thanks, I will commit this as it is. I will post a follow-up patch that uses the priority heuristic that I described above, and will work on related patches that you mentioned as well.


Repository:
  rL LLVM

https://reviews.llvm.org/D25520





More information about the cfe-commits mailing list