r284392 - Reapply r284383. The test failures were due to a missing dir in test/

Tim Northover via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 17 10:34:18 PDT 2016


Hi Krzysztof,

This still seems to be failing on Darwin:

/Users/tim/llvm/llvm/tools/clang/test/Driver/hexagon-toolchain-elf.c:9:14:
error: expected string not found in input
// CHECK000: "-cc1" {{.*}} "-internal-externc-isystem"
"{{.*}}/Inputs/hexagon_tree/Tools/bin/../target/hexagon/include"

The directory my Clang is actually choosing is
/Users/tim/llvm/llvm/tools/clang/test/Driver/Inputs/hexagon_tree/Tools/bin/hexagon/include,
and there is no hexagon_tree directory in ToT.

I think this might be something to do with git not actually recording
empty directories. Could you have another look?

Cheers.

Tim.

On 17 October 2016 at 08:30, Krzysztof Parzyszek via cfe-commits
<cfe-commits at lists.llvm.org> wrote:
> Author: kparzysz
> Date: Mon Oct 17 10:30:10 2016
> New Revision: 284392
>
> URL: http://llvm.org/viewvc/llvm-project?rev=284392&view=rev
> Log:
> Reapply r284383. The test failures were due to a missing dir in test/
>
> Added:
>     cfe/trunk/test/Driver/Inputs/hexagon_tree/Tools/bin/
> Modified:
>     cfe/trunk/lib/Driver/ToolChains.cpp
>
> Modified: cfe/trunk/lib/Driver/ToolChains.cpp
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/ToolChains.cpp?rev=284392&r1=284391&r2=284392&view=diff
> ==============================================================================
> --- cfe/trunk/lib/Driver/ToolChains.cpp (original)
> +++ cfe/trunk/lib/Driver/ToolChains.cpp Mon Oct 17 10:30:10 2016
> @@ -2970,7 +2970,7 @@ std::string HexagonToolChain::getHexagon
>    if (getVFS().exists(InstallRelDir = InstalledDir + "/../target"))
>      return InstallRelDir;
>
> -  return InstallRelDir;
> +  return InstalledDir;
>  }
>
>  Optional<unsigned> HexagonToolChain::getSmallDataThreshold(
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits


More information about the cfe-commits mailing list