[PATCH] D25621: DebugInfo: use DIAlignment type.

[David Blaikie via cfe-commits]

On Mon, Oct 17, 2016 at 4:37 AM Victor Leschuk <vleschuk at accesssoftek.com>
wrote:

> vleschuk marked an inline comment as done.
> vleschuk added inline comments.
>
>
> ================
> Comment at: include/clang/AST/ASTContext.h:83
>      uint64_t Width;
> -    unsigned Align;
> +    llvm::DIAlignment Align;
>      bool AlignIsRequired : 1;
> ----------------
> aprantl wrote:
> > I'm not sure we want to use a debug info type inside the AST. I think we
> only want to use them in CGDebugInfo.cpp.
> We use TypeInfo and related functions heavily in CGDebugInfo.cpp, leaving
> this field as "unsigned" will make us to perform conversions from
> "unsigned" to llvm::DIAlignment, I think having this changed will result in
> simpler code.
>

It'd still be a layering violation to have AST depend on debug info
types/concepts. If it makes sense to change it to uint32_t in AST, that'd
probably be reasonable.

- Dave


>
>
> https://reviews.llvm.org/D25621
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20161017/ae836cd8/attachment.html>