[clang-tools-extra] r284233 - [clang-move] Add header guard for the new header.

[Tim Northover via cfe-commits]

On 14 October 2016 at 13:33, Tim Northover <t.p.northover at gmail.com> wrote:
> On 14 October 2016 at 06:01, Haojian Wu via cfe-commits
> <cfe-commits at lists.llvm.org> wrote:
>> +  std::string GuardName(FileName);
>> +  if (IsHeader) {
>> +    std::replace(GuardName.begin(), GuardName.end(), '/', '_');
>> +    std::replace(GuardName.begin(), GuardName.end(), '.', '_');
>> +    std::replace(GuardName.begin(), GuardName.end(), '-', '_');
>
> I think this is causing problems with one of our bots that has an '@'
> in a path it uses. In general it seems like a whitelist based on what
> a C token is would be better than a blacklist of characters.
>
> Could you take a look?

Ping.

Tim.