[PATCH] D24864: [libcxxabi] Refactor pthread usage into a separate API
Asiri Rathnayake via cfe-commits
cfe-commits at lists.llvm.org
Fri Oct 14 16:58:52 PDT 2016
rmaprath added a comment.
In https://reviews.llvm.org/D24864#570935, @vitalybuka wrote:
> Maybe?
>
> - if (UNIX AND NOT (APPLE OR CYGWIN))
> + if (LIBCXXABI_ENABLE_THREADS AND UNIX AND NOT (APPLE OR CYGWIN))
> list(APPEND LIBCXXABI_SOURCES cxa_thread_atexit.cpp)
> endif()
>
Yes!
I was just about to say I don't know why it's even trying to build this, given that the library is configured with `-DLIBCXXABI_ENABLE_THREADS=OFF`.
Feel free to commit a fix :)
Cheers,
/ Asiri
https://reviews.llvm.org/D24864
More information about the cfe-commits
mailing list