[PATCH] D25597: Try to fix buildbot failure in VirtualFileSystem caused by r284129.
Eric Liu via cfe-commits
cfe-commits at lists.llvm.org
Fri Oct 14 02:12:35 PDT 2016
ioeric created this revision.
ioeric added a reviewer: bkramer.
ioeric added a subscriber: cfe-commits.
Since `remove_dots` does not delete leading "../" anymore, assertion test need
to be updated.
https://reviews.llvm.org/D25597
Files:
lib/Basic/VirtualFileSystem.cpp
Index: lib/Basic/VirtualFileSystem.cpp
===================================================================
--- lib/Basic/VirtualFileSystem.cpp
+++ lib/Basic/VirtualFileSystem.cpp
@@ -1477,8 +1477,9 @@
RedirectingFileSystem::lookupPath(sys::path::const_iterator Start,
sys::path::const_iterator End, Entry *From) {
#ifndef LLVM_ON_WIN32
- assert(!isTraversalComponent(*Start) &&
- !isTraversalComponent(From->getName()) &&
+ // FIXME: `remove_dots` does not remove leading "../" anymore, might need
+ // better test here.
+ assert(!Start->equals(".") && !isTraversalComponent(From->getName()) &&
"Paths should not contain traversal components");
#else
// FIXME: this is here to support windows, remove it once canonicalized
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D25597.74630.patch
Type: text/x-patch
Size: 786 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20161014/70f5b650/attachment.bin>
More information about the cfe-commits
mailing list