[PATCH] D25519: [CodeCompletion] Refactor: Extract two Objective-C block formatting related functions from FormatFunctionParameter

Manman Ren via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 12 10:43:34 PDT 2016


manmanren added a comment.

Cheers,
Manman



================
Comment at: lib/Sema/SemaCodeComplete.cpp:2165
 
+static void findTypeLocationForBlockDecl(const TypeSourceInfo *TSInfo,
+                                         FunctionTypeLoc &Block,
----------------
Please add comments for the helper function.


================
Comment at: lib/Sema/SemaCodeComplete.cpp:2279
+static std::string
+formatBlockPlaceholder(const PrintingPolicy &Policy, const NamedDecl *BlockDecl,
+                       FunctionTypeLoc &Block, FunctionProtoTypeLoc &BlockProto,
----------------
Comments here as well.


Repository:
  rL LLVM

https://reviews.llvm.org/D25519





More information about the cfe-commits mailing list