[PATCH] D25437: [clang-tidy] Fix template agrument false positives in unused-using-decls.

Aaron Ballman via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 11 05:34:25 PDT 2016


aaron.ballman added inline comments.


================
Comment at: test/clang-tidy/misc-unused-using-decls.cpp:191
+// n::N is using in the explicit template instantiations.
+template void h(n::M<N>* t);
----------------
hokein wrote:
> aaron.ballman wrote:
> > Can you add a test using a non-type template argument, like an integer literal? I believe that still causes the diagnostic, though do we want it to?
> Yeah, I agree that we need support non-type template arguments in the long term, but it seems out of scope of this patch (Supporting all non-type template arguments needs more stuff), I have added to FIXME.
Certainly; I would mostly like a test showing that we considered it and understand the current behavior. If the test has a FIXME comment with it, that's also totally fine.


https://reviews.llvm.org/D25437





More information about the cfe-commits mailing list