[PATCH] D25458: Don't create builtin declaration when looking for typo corrections in C++

[Nico Weber via cfe-commits]

thakis added a comment.

rtrieu: Is there some global "are we in typo correction?" bit somewhere already?



================
Comment at: lib/CodeGen/CGBuiltin.cpp:800
+  case Builtin::BI_byteswap_ulong:
+  case Builtin::BI_byteswap_uint64:
   case Builtin::BI__builtin_bswap16:
----------------
Is this an unrelated change?


================
Comment at: lib/Sema/SemaLookup.cpp:2013
 
-  if (LookupDirect(*this, R, LookupCtx)) {
+  if (LookupDirect(*this, R, LookupCtx, /*AllowBuiltinCreation=*/true)) {
     R.resolveKind();
----------------
Are you passing `false` anywhere? I can't find it (but I'm probably just blind) :-)


https://reviews.llvm.org/D25458